Polish Secrets Manager Integration - Githubissues

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring

https://awspring.io/

Apache License 2.0

589 stars 376 forks source link

Polish Secrets Manager Integration #743

Closed maciejwalkowiak closed 3 years ago

maciejwalkowiak commented 3 years ago

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring

:scroll: Description

Correct handling optional config data and failFast for old type of integration.

Fixes logging in AwsSecretsManagerConfigDataLocationResolver.

Handles the case when AwsSecretsManagerPropertySources returnsnull.

:bulb: Motivation and Context

Follow up to #721.

:green_heart: How did you test it?

Unit & integration tests.

:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] I updated reference documentation to reflect the change
[x] All tests passing
[ ] No breaking changes

maciejwalkowiak commented 3 years ago

That's me losing the battle with git and intellij