search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
589 stars 376 forks source link

Processing fifo messages with same groupId sequentially. See issue: h… #746

Closed tristanexsquare closed 3 years ago

tristanexsquare commented 3 years ago

:loudspeaker: Type of change

:scroll: Description

For FIFO queues the AsynchronousMessageListener groups messages with same messageGroupId into so called MessageGroups. The MessageExecutor (renamed to MessageGroupExecutor) handles the messages within those groups sequentially.

Messages from non-FIFO queues are handled as before with the only difference that they are also wrapped in a MessageGroup. Each separate message belongs to its own MessageGroup.

:bulb: Motivation and Context

Fixes https://github.com/spring-cloud/spring-cloud-aws/issues/756 Fixes #530

:green_heart: How did you test it?

See: SimpleMessageListenerContainerTest

I created 10 messages that belong to 3 different groups and returned these when invoking receiveMessage. Then I started the container and verified that the messages within the same group are handled in the order they have been returned by receiveMessage.

:pencil: Checklist

:crystal_ball: Next steps

pivotal-issuemaster commented 3 years ago

@tristanessquare Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@tristanessquare Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@tristanessquare Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@tristanessquare Thank you for signing the Contributor License Agreement!

fmalhe commented 3 years ago

This fix would save my life actually 😉. Any plans to get this merged soon?

joelhess commented 3 years ago

Any chance of getting this merged for the 2.3 release? Is there anything I can do to help it along?

maciejwalkowiak commented 3 years ago

@tristanessquare thanks for an update!

@joelhess it will be in 2.3. I am working on it now.