search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
589 stars 376 forks source link

Fix for #736 to allow security manager prefix without "/" in the front #753

Closed hariohmprasath closed 3 years ago

hariohmprasath commented 3 years ago

:loudspeaker: Type of change

:scroll: Description

The initial code always expected the "prefix" inside "secretmanager" to start with "/" in the front, which not be in true as AWS doesn't impose such restrictions. So the code change takes care of updating the regex to allow 0 or 1 occurrence of "/" as the first character while specifying the prefix inside "secretmanager"

:bulb: Motivation and Context

736

:green_heart: How did you test it?

:pencil: Checklist

:crystal_ball: Next steps

No additional steps required

pivotal-issuemaster commented 3 years ago

@hariohmprasath Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@hariohmprasath Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@hariohmprasath Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@hariohmprasath Thank you for signing the Contributor License Agreement!

maciejwalkowiak commented 3 years ago

Thanks @hariohmprasath for your contribution. We merged it in https://github.com/awspring/spring-cloud-aws/pull/33