spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
590 stars 373 forks source link

Support for registering & discovering applications using AWS CloudMap #757

Closed hariohmprasath closed 3 years ago

hariohmprasath commented 3 years ago

Type: Feature Support for registering & discovering applications using AWS CloudMap

Is your feature request related to a problem? Please describe. We have an application which is currently deployed in both ECS and EKS cluster that would need AWS CloudMap integration to enable service discovery. But depending upon where you deploy the CloudMap integration may vary, like below:

This makes it difficult to have a single codebase for both services that can control the CloudMap integration and makes it DevOps heavy

Describe the solution you'd like Similar to other Spring-boot AWS integration we can have the registry and discovery defined part of application or bootstrap yaml/properties file like below:

aws
 cloudmap
  registry
   namespace: cloudmap-namespace #Creates Cloudmap namespace - "API calls and DNS queries in VPCs"
   service: cloudmap-service #Create service if not exists
   healthcheck: /health
  discovery
   namespace: cloudmap-discovery-namespace
   service: cloudmap-discovery-service
   filterAttributes:
    - key: name
          value: value

This will help application developers to control most aspects of the CloudMap integration part of their application code, instead of defining them in CDK, CloudFormation or k8s deployment files

Describe alternatives you've considered Other alternative is to have the individual applications register themselves to AWS CloudMap service using AWS SDK. This leads to lot of code & logic duplications which would become difficult to manage

Additional context If you guys like this please let me know. I am currently working on a pull request will submit it for review once it's ready.

eddumelendez commented 3 years ago

Closing this one in favor of the one added at https://github.com/awspring/spring-cloud-aws