search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
590 stars 373 forks source link

Provide ClientHttpRequestInterceptor to make aws-sig-4 signed request with the RestTemplate #767

Closed joshiste closed 3 years ago

joshiste commented 3 years ago

:loudspeaker: Type of change

:scroll: Description

Provide a ClientHttpRequestInterceptor which signs requests using the AWS Signature V4 which is needed for example to call various AWS services (like API Gateway)

:bulb: Motivation and Context

Currently imho it is tedious and lacking a good documentation on how to make signed request using the RestTemplate to the API Gateway. Alternative to the RestTemplate you can use generated SDKs or subclassing the AmazonWebServiceClient.

Imho being able to make signed requests using the RestTemplate has the benefit for the spring developers to work with a familiar API.

:green_heart: How did you test it?

There are two test verifying the signatures of requests from the aws-sig-v4-test-suite.

:pencil: Checklist

:crystal_ball: Next steps

As this is more or less just a preview of the feature and also lacking support for the WebClient, I am happy to discuss if this is a desirable feature and if yes what further steps are needed to see this feature integrated.

maciejwalkowiak commented 3 years ago

Thanks @joshiste for the PR! Would you mind closing this one and creating new one in https://github.com/awspring/spring-cloud-aws repository? https://github.com/spring-cloud/spring-cloud-aws is in the maintenance mode and everything new moves to awspring.

joshiste commented 3 years ago

moved to https://github.com/awspring/spring-cloud-aws/pull/113