QueueMessageChannel.receive() implementation doesn't align with PollableChannel 's definition

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring

https://awspring.io/

Apache License 2.0

589 stars 376 forks source link

Open jorgenota opened 3 years ago

jorgenota commented 3 years ago

Type: Bug

Component:

SQS

Describe the bug

According to javadoc of PollableChannel, MessageChannel.INDEFINITE_TIMEOUT should be used to represent indefinite timeout (instead of 0).
The timeout parameter of PollableChannel.receive() method represents the timeout in milliseconds (so it should be transformed into seconds when building the ReceiveMessageRequest).

This PR betters shows the suggested fix: #769