spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
589 stars 376 forks source link

fix: #777 - Add support for FIFO headers for SNS FIFO topics. #778

Closed dmitry-weirdo closed 2 years ago

dmitry-weirdo commented 3 years ago

:loudspeaker: Type of change

:scroll: Description

Added support of message-group-id and message-deduplication-id headers. They will be set to the appropriate fields of PublishRequest. This will make it possible to post to a FIFO SNS topic with NotificationMessagingTemplate.

:bulb: Motivation and Context

Fixes https://github.com/spring-cloud/spring-cloud-aws/issues/777.

:green_heart: How did you test it?

Tested with a real FIFO queue on AWS. Also works with Localstack.

:pencil: Checklist

:crystal_ball: Next steps

pivotal-cla commented 3 years ago

@dmitry-weirdo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 3 years ago

@dmitry-weirdo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 3 years ago

@dmitry-weirdo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 3 years ago

@dmitry-weirdo Thank you for signing the Contributor License Agreement!

maciejwalkowiak commented 2 years ago

Thanks for the PR, this feature has been already implemented in https://github.com/awspring/spring-cloud-aws/pull/130

https://github.com/spring-cloud/spring-cloud-aws is a maintenance only repository, development moved to https://github.com/awspring/spring-cloud-aws