spring-attic / spring-cloud-dashboard

Apache License 2.0
31 stars 21 forks source link

Refactor ApplicationType concept #4

Open jvalkeal opened 7 years ago

jvalkeal commented 7 years ago

org.springframework.cloud.deployer.admin.core.ApplicationType currently defines source, processor, sink and task. This is something what base deployer admin core would use which means that we can't have hard-coded types as deployer admin core would not know anything about streams.

ApplicationType is generally used:

If this concept is changed to be more generic then problems we're facing is illustrated with a simple example. Lets make this type as s single property list.

jvalkeal commented 7 years ago

I was kinda playing with ideas what we have in MediaType/MimeType as those know type and subtype.

If we remove hardcoded enumeration of possible app types, then base system defines some generic ones which might be plain generic boot apps and tasks. Dataflow should then add its own types.

deployer/generic
deployer/task
dataflow/source
dataflow/sink
dataflow/processor

This might make it easier for component using these to understand from where the type originates.

Thought trouble with this is that existing commands only knows about raw type name.