search

spring-attic / spring-cloud-dataflow-server-cloudfoundry

Spring Cloud Data Flow Implementation for Cloud Foundry
http://cloud.spring.io/spring-cloud-dataflow-server-cloudfoundry/
Apache License 2.0
21 stars 42 forks source link

Test that hikari connection works on CF #406

Closed markpollack closed 6 years ago

markpollack commented 6 years ago

Deploy the SCDF server to CF and investigate if the hikari connection pool is configured to 4 connections via the cloudfoundry connector library.

sabbyanandan commented 6 years ago

I don't see the connection pool settings when I hit the /configprops endpoint. The server, however, it appears to start with Hikari connection.

2018-05-08T11:17:33.06-0700 [APP/PROC/WEB/0] OUT 2018-05-08 18:17:33.068  INFO 15 --- [           main] o.s.c.s.r.PooledDataSourceCreator        : Found HikariCP on the classpath. Using it for DataSource connection pooling.

..
..

2018-05-08T11:17:40.91-0700 [APP/PROC/WEB/0] OUT 2018-05-08 18:17:40.912  INFO 15 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Starting...
2018-05-08T11:17:41.11-0700 [APP/PROC/WEB/0] OUT 2018-05-08 18:17:41.113  INFO 15 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Start completed.
sabbyanandan commented 6 years ago

As an FYI, I've been doing a lot of demos on the latest 1.5 BS version and the stream-builder form comes up always as expected. No more hang-ups and the 500 errors.

markpollack commented 6 years ago

The connector library does not set the size to 4, this will be fixed in a future release. ATM, the default is 10 from Hikari itself. 

com.zaxxer.hikari.HikariConfig : maximumPoolSize.................10

via setting --logging.level.com.zaxxer.hikari=debug

This limits use of SCDF on PWS using the free tier of mysql, but it doesn't seem worth it to go back to the tomcat pool just for the CF server.