Feign Etcd client implementation

spring-attic / spring-cloud-etcd

Apache License 2.0

144 stars 60 forks source link

Feign Etcd client implementation #15

Closed lburgazzoli closed 9 years ago

lburgazzoli commented 9 years ago

As today spring-cloud-etcd uses etcd4j (project to which I've contribute a few things) as Etcd client but as Netflix's Feign is already a dependency I was wondering if it would make sense to implement a custom Etcd client to:

reduce dependencies and base the implementation on common SpringCloudOSS technologies
tailoring the client to the needs of spring-cloud-etcd (i.e. support for Etcd healt indicator)

Writing an Etcd client with Netflix's Feign is very easy.

spencergibb commented 9 years ago

In spring-cloud-consul I specifically removed a feign consul client. I'm not keen on maintaining clients to all these different services.

lburgazzoli commented 9 years ago

Ah ok, so it make sense to stick with ecd4j