EtcdHealthIndicator should not poll etcd if spring.cloud.etcd.enabled=false

spring-attic / spring-cloud-etcd

Apache License 2.0

144 stars 60 forks source link

EtcdHealthIndicator should not poll etcd if spring.cloud.etcd.enabled=false #21

Open otrosien opened 8 years ago

otrosien commented 8 years ago

at the moment actuator health hangs for quite some time waiting for an etcd reply on localhost:4001, which should not be even contacted if the configuration disabled spring.cloud.etcd IMO.

otrosien commented 8 years ago

alternatively, exclude etcdHealthIndicator completely if etcd is disabled..? the more I think about it, the more it actually makes sense to just exlude it. Application health status should be UP in the end, if admin decides to not use etcd. @spencergibb wdyt?

otrosien commented 8 years ago

closing PR#22 - so the solution should probably look like this:

Do not add etcd health checks if spring.cloud.etcd.enabled=false or spring.cloud.etcd.healthcheck.enabled=false (new config property)