search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
705 stars 693 forks source link

Add integration test for micrometer/stackdriver monitoring #2402

Open elefeint opened 4 years ago

elefeint commented 4 years ago

Follow up to #2391.

eddumelendez commented 4 years ago

@elefeint the test for the sample submitted at #2455 applies to this issue?

elefeint commented 4 years ago

We typically also create an integration test closer to where the functionality is defined -- in this case, it would be in the autoconfiguration project. But it's true that it's sort of redundant now that we integration test sample applications.

@meltsufin What do you think? The integration test in this case would be very similar to the sample app's test.

meltsufin commented 4 years ago

Ideally, we would have one in auto-config as well. That being said, coverage is coverage, regardless where it comes from. So, it's all good as far as I'm concerned.