search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
705 stars 693 forks source link

fix slice query execution in PartTreeDatastoreQuery #2452

Closed dmitry-s closed 4 years ago

dmitry-s commented 4 years ago

fixes failing CI test

@viniciusccarvalho FYI this PR fixes issues introduced in #2437

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more here

codecov[bot] commented 4 years ago

Codecov Report

Merging #2452 into master will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2452      +/-   ##
============================================
- Coverage     74.05%   74.03%   -0.03%     
+ Complexity     2120     2119       -1     
============================================
  Files           264      264              
  Lines          7662     7663       +1     
  Branches        791      790       -1     
============================================
- Hits           5674     5673       -1     
- Misses         1620     1622       +2     
  Partials        368      368
Flag Coverage Δ Complexity Δ
#unittests 74.03% <100.00%> (-0.03%) 2119.00 <0.00> (-1.00)
Impacted Files Coverage Δ Complexity Δ
...store/repository/query/PartTreeDatastoreQuery.java 91.44% <100.00%> (+0.04%) 50.00 <0.00> (-1.00) :arrow_up:
...tastore/GcpDatastoreEmulatorAutoConfiguration.java 65.51% <0.00%> (-6.90%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f5956d...9ffd6fc. Read the comment docs.