search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

Bound the acknowledging operation methods' type parameter #2539

Closed celcius112 closed 3 years ago

celcius112 commented 3 years ago

Modify PubSubSubscriberOperations#ack, PubSubSubscriberOperations#nack and PubSubSubscriberOperations#modifyAckDeadline. This is a breaking change for implementations of PubSubSubscriberOperations, but not for callers.

see https://github.com/spring-cloud/spring-cloud-gcp/issues/2538

codecov[bot] commented 3 years ago

Codecov Report

Merging #2539 into master will decrease coverage by 7.20%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2539      +/-   ##
============================================
- Coverage     81.48%   74.28%   -7.21%     
+ Complexity     2389     2162     -227     
============================================
  Files           267      267              
  Lines          7762     7762              
  Branches        803      803              
============================================
- Hits           6325     5766     -559     
- Misses         1098     1626     +528     
- Partials        339      370      +31
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.28% <ø> (ø) 2162.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ramework/cloud/gcp/pubsub/core/PubSubTemplate.java 27.50% <ø> (ø) 6.00 <0.00> (ø)
...bsub/core/subscriber/PubSubSubscriberTemplate.java 82.14% <ø> (ø) 38.00 <0.00> (ø)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f939bf...adfc986. Read the comment docs.