search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

Add query methods that return Slice to DatastoreTemplate to allow pagination #2541

Closed dmitry-s closed 3 years ago

dmitry-s commented 3 years ago

fixes #2535

codecov[bot] commented 3 years ago

Codecov Report

Merging #2541 into master will decrease coverage by 7.24%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2541      +/-   ##
============================================
- Coverage     81.48%   74.24%   -7.25%     
+ Complexity     2389     2170     -219     
============================================
  Files           267      267              
  Lines          7762     7788      +26     
  Branches        803      807       +4     
============================================
- Hits           6325     5782     -543     
- Misses         1098     1630     +532     
- Partials        339      376      +37
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.24% <66.66%> (-0.05%) 2170.00 <7.00> (+8.00) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oud/gcp/data/datastore/core/DatastoreTemplate.java 86.27% <60.86%> (-10.29%) 128.00 <4.00> (-11.00)
...store/repository/query/PartTreeDatastoreQuery.java 88.70% <66.66%> (-5.41%) 51.00 <1.00> (-1.00)
.../data/datastore/core/DatastoreResultsIterable.java 92.85% <100.00%> (-7.15%) 6.00 <2.00> (+1.00) :arrow_down:
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fee908...0e9887a. Read the comment docs.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

68.0% 68.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more here

meltsufin commented 3 years ago

@dmitry-s Did you mean DatastoreTemplate? 😄