spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
706 stars 693 forks source link

Force override of spring.datasource.url #2558

Closed meltsufin closed 4 years ago

meltsufin commented 4 years ago

Also:

Fixes: #2537. Related: #272.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more here

codecov[bot] commented 4 years ago

Codecov Report

Merging #2558 into master will decrease coverage by 7.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2558      +/-   ##
============================================
- Coverage     81.51%   74.29%   -7.22%     
+ Complexity     2389     2162     -227     
============================================
  Files           267      267              
  Lines          7762     7766       +4     
  Branches        803      803              
============================================
- Hits           6327     5770     -557     
- Misses         1096     1626     +530     
- Partials        339      370      +31     
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.29% <100.00%> (+0.01%) 2162.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...work/cloud/gcp/autoconfigure/sql/DatabaseType.java 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...utoconfigure/sql/GcpCloudSqlAutoConfiguration.java 39.39% <100.00%> (+3.91%) 2.00 <0.00> (ø)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8200d7c...9a0473b. Read the comment docs.