search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

Initial GitHub Actions workflow to test on multiple JDK versions #2568

Closed geertjanw closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #2568 into master will decrease coverage by 7.24%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2568      +/-   ##
============================================
- Coverage     81.44%   74.20%   -7.25%     
+ Complexity     2397     2170     -227     
============================================
  Files           267      267              
  Lines          7794     7792       -2     
  Branches        807      807              
============================================
- Hits           6348     5782     -566     
- Misses         1103     1634     +531     
- Partials        343      376      +33
Flag Coverage Δ Complexity Δ
integration ? ?
unittests 74.20% <ø> (-0.06%) 2170.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
...ramework/cloud/gcp/vision/DocumentOcrTemplate.java 17.64% <0.00%> (-73.53%) 4.00% <0.00%> (-5.00%)
...work/cloud/gcp/bigquery/core/BigQueryTemplate.java 0.00% <0.00%> (-71.70%) 0.00% <0.00%> (-8.00%)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22a9608...3cc1e8e. Read the comment docs.

meltsufin commented 3 years ago

@ttomsu Can you take a look, since you're familiar with GH actions? I don't see any harm in this, but I think the Spring Team is already testing several JDK versions in their Jenkins CI. cc/ @artembilan

artembilan commented 3 years ago

True. We really have those plans in the Spring GCP project pipeline: https://jenkins.spring.io/search/?q=gcp&Jenkins-Crumb=db7f22a2c893ab2e18235addf81bdff6586bcb80e990fca5f96670713e27c09a

Not sure though how is it going to be when we migrate project to your side. So, probably using GH actions is the right direction to go. (Not familiar though what is that)

geertjanw commented 3 years ago

True. We really have those plans in the Spring GCP project pipeline: https://jenkins.spring.io/search/?q=gcp&Jenkins-Crumb=db7f22a2c893ab2e18235addf81bdff6586bcb80e990fca5f96670713e27c09a

Not sure though how is it going to be when we migrate project to your side. So, probably using GH actions is the right direction to go. (Not familiar though what is that)

GitHub has JDKs that are used automatically when you run GitHub Action workflows, such as for building and testing, which occur on the GitHub infrastructure. It's all well integrated, in the Actions tab of GitHub repos, via the configuration file in this PR.

geertjanw commented 3 years ago

Here you can see how it looks after the process is complete, on my fork of your repo, which happens automatically whenever a new merge is done in the repo:

https://github.com/geertjanw/spring-cloud-gcp/actions/runs/331803390

meltsufin commented 3 years ago

We are doing this with GH Actions in the new repo: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/f404bac2efd17bad3eef20a7317b7216c3eebb29/.github/workflows/buildAndTest.yaml#L24

ttomsu commented 3 years ago

As @meltsufin already mentioned, we're doing this in the new repo. This repo will become deprecated with the Ilford (2020.0.0) Spring Cloud Release, so if you have additional things you'd like to see/test out I'd love to see them in the new repo.

meltsufin commented 3 years ago

Just to be clear, this repo will remain for ongoing support of 1.x versions, including support for Spring Cloud Hoxton (Spring Cloud GCP v1.2.x).