spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
706 stars 693 forks source link

add != to PartTreeFirestoreQuery #2569

Closed dmitry-s closed 4 years ago

dmitry-s commented 4 years ago

fixes #2563

dzou commented 4 years ago

Looks good. @meltsufin @dmitry-s -- Wanted to revisit our discussion of the new repo. Do you plan to include these changes in the new repo? I think we are getting a little out of sync with a few PRs related to datastore/firestore.

dmitry-s commented 4 years ago

adding support for NOT_IN as well

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. Read more here

codecov[bot] commented 4 years ago

Codecov Report

Merging #2569 into master will decrease coverage by 7.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2569      +/-   ##
============================================
- Coverage     81.44%   74.23%   -7.21%     
+ Complexity     2397     2170     -227     
============================================
  Files           267      267              
  Lines          7792     7794       +2     
  Branches        807      807              
============================================
- Hits           6346     5786     -560     
- Misses         1103     1632     +529     
- Partials        343      376      +33     
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.23% <100.00%> (-0.02%) 2170.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...store/repository/query/PartTreeFirestoreQuery.java 91.34% <100.00%> (-3.76%) 24.00 <0.00> (-2.00)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
...ramework/cloud/gcp/vision/DocumentOcrTemplate.java 17.64% <0.00%> (-73.53%) 4.00% <0.00%> (-5.00%)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c807e8...7127276. Read the comment docs.