search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

fix converters override in Spring Data Spanner #2580

Closed dmitry-s closed 3 years ago

dmitry-s commented 3 years ago

fixes #2579

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. Read more here

codecov[bot] commented 3 years ago

Codecov Report

Merging #2580 (a402409) into master (4c807e8) will decrease coverage by 7.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2580      +/-   ##
============================================
- Coverage     81.44%   74.23%   -7.21%     
+ Complexity     2397     2171     -226     
============================================
  Files           267      267              
  Lines          7792     7798       +6     
  Branches        807      807              
============================================
- Hits           6346     5789     -557     
- Misses         1103     1632     +529     
- Partials        343      377      +34
Flag Coverage Δ Complexity Δ
integration ? ?
unittests 74.23% <100.00%> (-0.02%) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ata/spanner/core/convert/SpannerReadConverter.java 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...ta/spanner/core/convert/SpannerWriteConverter.java 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c807e8...a402409. Read the comment docs.

ttomsu commented 3 years ago

Please cherry-pick into new repo.