search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

Firestore - switch to commit to avoid write limitations #2600

Closed dmitry-s closed 3 years ago

dmitry-s commented 3 years ago

fixes #2561 fixes #2574

dmitry-s commented 3 years ago

@meltsufin there is actually nothing to compare, the old way was unable to write more than a couple of thousands - that's why I thought it was faster.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11. Read more here

codecov[bot] commented 3 years ago

Codecov Report

Merging #2600 (2cd9efb) into master (edce3ac) will increase coverage by 0.05%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2600      +/-   ##
============================================
+ Coverage     74.05%   74.10%   +0.05%     
  Complexity     2174     2174              
============================================
  Files           267      267              
  Lines          7824     7816       -8     
  Branches        810      810              
============================================
- Hits           5794     5792       -2     
+ Misses         1652     1646       -6     
  Partials        378      378
Flag Coverage Δ Complexity Δ
integration ? ?
unittests 74.10% <0.00%> (+0.05%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rk/cloud/gcp/data/firestore/FirestoreTemplate.java 73.07% <0.00%> (-2.93%) 52.00 <0.00> (ø)
...cp/data/firestore/util/ObservableReactiveUtil.java 69.69% <ø> (+20.76%) 3.00 <0.00> (ø)
...tastore/GcpDatastoreEmulatorAutoConfiguration.java 58.62% <0.00%> (-6.90%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edce3ac...2cd9efb. Read the comment docs.