search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

Update pubsub docs with correct batching values #2622

Closed elefeint closed 3 years ago

elefeint commented 3 years ago

Gax default builder settings turn off batching for every relevant setting.

Our documentation assumed that batching is only controlled by the boolean spring.cloud.gcp.pubsub.publisher.batching.enabled property, which is not accurate.

Fixes #2621.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11. Read more here

codecov[bot] commented 3 years ago

Codecov Report

Merging #2622 (939a6d7) into master (df64a4a) will decrease coverage by 7.32%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2622      +/-   ##
============================================
- Coverage     81.30%   73.97%   -7.33%     
+ Complexity     2399     2169     -230     
============================================
  Files           267      267              
  Lines          7813     7813              
  Branches        809      809              
============================================
- Hits           6352     5780     -572     
- Misses         1114     1653     +539     
- Partials        347      380      +33
Flag Coverage Δ Complexity Δ
integration ? ?
unittests 73.97% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ringframework/cloud/gcp/data/firestore/AutoId.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (-2.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
...ramework/cloud/gcp/vision/DocumentOcrTemplate.java 17.64% <0.00%> (-73.53%) 4.00% <0.00%> (-5.00%)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df64a4a...939a6d7. Read the comment docs.