Closed mac2000 closed 3 years ago
@mac2000 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@mac2000 Thank you for signing the Contributor License Agreement!
Merging #2624 (b9dc229) into master (839373b) will decrease coverage by
7.32%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2624 +/- ##
============================================
- Coverage 81.30% 73.97% -7.33%
+ Complexity 2399 2169 -230
============================================
Files 267 267
Lines 7813 7813
Branches 809 809
============================================
- Hits 6352 5780 -572
- Misses 1114 1653 +539
- Partials 347 380 +33
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
integration | ? |
? |
|
unittests | 73.97% <ø> (ø) |
0.00 <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 839373b...a04a441. Read the comment docs.
heh, and it did not
in idea with java 15, everything seems to be fine but in CI with java 8 it brokes, after few attempts, it seems that I was able to make it working back by downgrading error-prone back to 2.3.4 but only for java 8
not sure whether it is a good approach or not but at moment have no idea what to do next
arghhhh, codecov is red 😂
should I add some tests for coverage to become +7%?
but then this PR won't be about upgrading error-prone
is there a way to bypass it?
arghhhh, codecov is red
should I add some tests for coverage to become +7%?
but then this PR won't be about upgrading error-prone
is there a way to bypass it?
Hey don't worry -- we can ignore the codecov for your PR since it's just upgrading the error prone version. I'll take a look.
Did some more digging, looks like someone else has same problem: https://github.com/codehaus-plexus/plexus-compiler/issues/77
However I'm not yet sure how they resolved their problem.
I am fine with the manual override of the version, just add a comment on the line above to remind people why it's there.
Done.
hopefully will fix the issue with error-prone, got the same issue but with a different class, did try to switch between 8, 11, 15 but the error still persists, after upgrading error-prone at least got further