search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 694 forks source link

fixes #2514 will use given project id if any and fallback to unused #2625

Closed mac2000 closed 3 years ago

mac2000 commented 3 years ago

fixes #2514 by using given project id, indeed it might be used in many other places, e.g. to reset database we can curl -x delete /project/{projectId} so instead of trying to figure out what default are we can use given option and fallback to unused

codecov[bot] commented 3 years ago

Codecov Report

Merging #2625 (1eae20b) into master (839373b) will decrease coverage by 7.37%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2625      +/-   ##
============================================
- Coverage     81.30%   73.92%   -7.38%     
+ Complexity     2399     2169     -230     
============================================
  Files           267      267              
  Lines          7813     7816       +3     
  Branches        809      809              
============================================
- Hits           6352     5778     -574     
- Misses         1114     1658     +544     
- Partials        347      380      +33
Flag Coverage Δ Complexity Δ
integration ? ?
unittests 73.92% <0.00%> (-0.06%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00 <0.00> (-4.00)
...ringframework/cloud/gcp/data/firestore/AutoId.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (-2.00%)
...ramework/cloud/gcp/vision/DocumentOcrTemplate.java 17.64% <0.00%> (-73.53%) 4.00% <0.00%> (-5.00%)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 839373b...1eae20b. Read the comment docs.

mac2000 commented 3 years ago

The same story as here I even added one more dedicated test to the proposed change but coverage is bad :(

ttomsu commented 3 years ago

LGTM - @dzou, mind taking a look too?