Closed mac2000 closed 3 years ago
Merging #2625 (1eae20b) into master (839373b) will decrease coverage by
7.37%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #2625 +/- ##
============================================
- Coverage 81.30% 73.92% -7.38%
+ Complexity 2399 2169 -230
============================================
Files 267 267
Lines 7813 7816 +3
Branches 809 809
============================================
- Hits 6352 5778 -574
- Misses 1114 1658 +544
- Partials 347 380 +33
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
integration | ? |
? |
|
unittests | 73.92% <0.00%> (-0.06%) |
0.00 <0.00> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 839373b...1eae20b. Read the comment docs.
The same story as here I even added one more dedicated test to the proposed change but coverage is bad :(
LGTM - @dzou, mind taking a look too?
fixes #2514 by using given project id, indeed it might be used in many other places, e.g. to reset database we can
curl -x delete /project/{projectId}
so instead of trying to figure out what default are we can use given option and fallback tounused