search

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring
Apache License 2.0
704 stars 696 forks source link

Updated SecretManager from v1beta1 to v1 #2639

Closed gwhitehawk closed 3 years ago

gwhitehawk commented 3 years ago

SecretManager is in GA since Q1 2020.

pivotal-issuemaster commented 3 years ago

@gwhitehawk Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@gwhitehawk Thank you for signing the Contributor License Agreement!

codecov[bot] commented 3 years ago

Codecov Report

Merging #2639 (d0f63d2) into master (52e0c17) will decrease coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2639      +/-   ##
============================================
- Coverage     73.93%   73.88%   -0.06%     
  Complexity     2169     2169              
============================================
  Files           267      267              
  Lines          7819     7819              
  Branches        811      811              
============================================
- Hits           5781     5777       -4     
- Misses         1656     1660       +4     
  Partials        382      382
Flag Coverage Δ Complexity Δ
unittests 73.88% <ø> (-0.06%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...anager/GcpSecretManagerBootstrapConfiguration.java 65.00% <ø> (ø) 3.00 <0.00> (ø)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../gcp/secretmanager/SecretManagerPropertyUtils.java 81.08% <ø> (ø) 6.00 <0.00> (ø)
...cloud/gcp/secretmanager/SecretManagerTemplate.java 98.85% <ø> (ø) 21.00 <0.00> (ø)
...tastore/GcpDatastoreEmulatorAutoConfiguration.java 58.62% <0.00%> (-13.80%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e0c17...d0f63d2. Read the comment docs.

dzou commented 3 years ago

Thank you @gwhitehawk ! I just merged in #2638 so will close this one.