Health Indicator for Cloud Spanner

spring-attic / spring-cloud-gcp

Integration for Google Cloud Platform APIs with Spring

Apache License 2.0

704 stars 696 forks source link

Health Indicator for Cloud Spanner #2680

Closed ikeyat closed 2 years ago

ikeyat commented 2 years ago

I think Spring Boot's DataSourceHealthIndicator does not work for spring-cloud-gcp-data-spanner because it does not use JDBC DataSource. A custom health indicator Such as SpannerHealthIndicator and its auto configures should be added into spring-cloud-gcp-data-spanner to avoid boilerplate.

https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html#actuator.endpoints.health.writing-custom-health-indicators

suztomo commented 2 years ago

I copied this feature request to https://github.com/GoogleCloudPlatform/spring-cloud-gcp/issues/640 (newer repository)

elefeint commented 2 years ago

Closing this one; will discuss on the new repo issue.