spring-attic / spring-cloud-pipelines

[DEPRECATED] Codebase containing Concourse and Jenkins opinionated pipelines. Moved to https://github.com/CloudPipelines/
https://github.com/CloudPipelines/
Apache License 2.0
235 stars 175 forks source link

The params order in deployservice is wrong into tools/k8s-helper.sh. #186

Closed davsuapas closed 6 years ago

davsuapas commented 6 years ago

I think that the params order in deployservice is wrong into k8s-helper.sh. I think what the correct is: deployService "github-rabbitmq" "rabbitmq" "scpipelines/github-analytics-stub-runner-boot-classpath-stubs:latest". I could fix if you wish.

tools/k8s-helper.sh:

setup-prod-infra)
        copyK8sYamls
        deployService "rabbitmq" "github-rabbitmq" "scpipelines/github-analytics-stub-runner-boot-classpath-stubs:latest"
        deployService "eureka" "github-eureka" "scpipelines/github-eureka:latest"
        export MYSQL_USER
        MYSQL_USER=username
        export MYSQL_PASSWORD
        MYSQL_PASSWORD=password
        export MYSQL_ROOT_PASSWORD
        MYSQL_ROOT_PASSWORD=rootpassword
        deployService "mysql" "mysql-github-analytics"
        ;;
marcingrzejszczak commented 6 years ago

Great catch. Should be better now!