Support overriding schedule properties

[chrisjs]

Resolves #11

[chrisjs]

there are a few properties wrapped up in this so ive added some testing notes here to help speed that process along:

• goto dashboard

• bulk import: http://bit.ly/Clark-GA-task-applications-docker

• create a timestamp task

• schedule the task

  • cron expression (use whatever tho): *
  • task properties - used the properties in "test property examples" below based on test case.

• test property examples:

  • scheduler.kubernetes.imagePullPolicy = Always
  • scheduler.kubernetes.entryPointStyle = boot
  • scheduler.kubernetes.environmentVariables = MYVAR1=MYVAL1
  • scheduler.kubernetes.taskServiceAccountName = myserviceacct
  • scheduler.kubernetes.imagePullSecret = mypullsecret

• when a scheduled task pod appears inspect the contents:

  • kubectl get POD_NAME -o yaml
  • verify changes to properties are reflected in the output
  • verification notes / some indicators properties are passed correctly:
  • imagePullPolicy: found by searching the yaml output and verifying the value
  • entryPointStyle: an env var SPRING_APPLICATION_JSON will be in the yaml output with values in JSON
  • environmentVariables: found by searching the yaml output and verifying its present
  • taskServiceAccountName:
    • a service account must be created otherwise pods will never get scheduled, as shown for example in kubectl get events: Error creating: pods "schedule1-1540342800-" is forbidden: error looking up service account default/none: serviceaccount "myserviceacct" not found
    • to create a service account: kubectl create serviceaccount myserviceacct
    • verification can be done by observing pods being created and searching the yaml output, verifying its present
  • imagePullSecret: create a task using a private image, schedule the task without setting an imagePullSecret and observe it fails, ie: doing a kubectl describe POD_NAME and verifying the events show something similar to Error response from daemon: pull access denied for....
    • to create a secret, follow the guide at: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ and then use the created secret name as the value to the scheduler.kubernetes.imagePullSecret property. schedule the task and verify it schedules as expected

[chrisjs]

updated per review comments

[cppwfs]

LGTM

[cppwfs]

Squashed Merged