spring-attic / spring-cloud-scheduler-kubernetes

Apache License 2.0
8 stars 10 forks source link

Add support for nodeSelectors for the scheduled jobs/tasks #25

Closed sabbyanandan closed 5 years ago

sabbyanandan commented 5 years ago

As a user, similar to what we have in K8s-deployer, I'd like to schedule the jobs/task to run on the nodes that match the node selector criteria.

We would have to decide whether the nodeSelector is defined as a deployer vs. a generic deployment property. Depending on what comes out of it, we could possibly also revisit the K8s-deployer to consolidate and represent the support for nodeSelector consistently.

The docs, of course, it requires an update when we add it.

sabbyanandan commented 5 years ago

Update: In the next minor release, we are merging K8s-scheduler implementation into K8s-deployer proper. So, no more duplicate codebase; likewise, there will be support for all the existing K8s overrides including volumeMounts, podAnnotations, jobAnnotations, nodeSelectors, and others.

For more details, please review: https://github.com/spring-cloud/spring-cloud-deployer/issues/310

And the child stories: image

This project will not be maintained after the next release.