Add IBM MQ implementation

spring-attic / spring-cloud-stream-binder-jms

Other

33 stars 56 forks source link

Add IBM MQ implementation #9

Closed donovanmuller closed 7 years ago

donovanmuller commented 7 years ago

Besides the actual JMS binder implementation, this PR also contains:

build profiles - probably a mute point once #7 is merged
JmsBinderConfigurationProperties for global JMS binder configuration.
AnonymousNamingStrategy to cater for apps with default settings (no consumer group defined).
Allow e2e test implementations to override test methods.
Parse JMS headers and replace illegal - characters in header names with _. Addresses #8.

mbogoevici commented 7 years ago

Thanks @donovanmuller - this an excellent and welcome contribution, especially as we are gearing up towards the Chelsea release train of Spring Cloud Stream - since this hasn't been released yet, it's the best moment to bump up the dependency on SCSt to 1.2.0.

This should be merged in conjunction with the separation of binders in individual repositories (as per #7). Once this is merged, we can continue with the work in https://github.com/spring-cloud/spring-cloud-stream/issues/745 - ensuring that the provisioning API is JMS-agnostic (which is another driver of having this dependent on SCSt 1.2.0).

I'll review and merge this and we can proceed with the next steps, I guess.

mbogoevici commented 7 years ago

@donovanmuller After a quick review of the changes, would it be possible to split this PR in two parts?

one that would go against the common stuff in this repository containing all the core changes
one that would be the implementation of the IBM MQ binder as a PR against the newly created https://github.com/spring-cloud/spring-cloud-stream-binder-ibm-mq

We are in the process of restructuring the JMS binders (already moved Solace) by keeping them in their own repositories so restructuring the PR would go a long way towards facilitating that.

Thanks!

donovanmuller commented 7 years ago

@mbogoevici No problem 👍

donovanmuller commented 7 years ago

https://github.com/spring-cloud/spring-cloud-stream-binder-jms/pull/9/commits/3d240ae844b1ebc626e1cff5c625d5b154b577b8 is in preparation for the split to the spring-cloud-stream-binder-ibm-mq repo

donovanmuller commented 7 years ago

Closing this PR to make way for separate PR's as per https://github.com/spring-cloud/spring-cloud-stream-binder-jms/pull/9#issuecomment-269007631