spring-attic / spring-dsl

Experimental Spring Dsl Library around Language features
Apache License 2.0
12 stars 6 forks source link

Support different jsonrpc response types #1

Open jvalkeal opened 5 years ago

jvalkeal commented 5 years ago

Currently when textDocument/documentSymbol is handled where lsp spec response is DocumentSymbol[] | SymbolInformation[] | null. Symbolizer has a return type of Flux<DocumentSymbol> and we assume via org.springframework.dsl.lsp.server.controller.TextDocumentLanguageServerController.documentSymbol(DocumentSymbolParams, JsonRpcSession) returning array of DocumentSymbol's. It's annoying that you can't really handle return type of SymbolInformation.

While we want to create higher lever service interfaces, on lsp level we should still be able to be compatible with a protocol itself.