spring-attic / spring-ide

Spring Development Environment for Eclipse
299 stars 126 forks source link

Spring Boot configuration property auto-completion does not offer properties on super classes #315

Closed wilkinsona closed 5 years ago

wilkinsona commented 6 years ago

When auto-completing spring.security.oauth2.client.registration.login.mylogin. only two properties are offered: redirect-uri and redirect-uri-template. These are both on org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientProperties.LoginClientRegistration. However, LoginClientRegistration inherits several other properties from org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientProperties.BaseClientRegistration but these are not offered by auto-completion. I am using 3.9.5.201807030714-RELEASE.

martinlippert commented 5 years ago

@kdvolder Can you take a look?

kdvolder commented 5 years ago

I remember cutting a corner there. So I can confirm we don't currently examine the type hierarchy to find additional bean properties in inherited methods.

Is this fixable, I'd say yes. Might pose a little challenge because operations on the type hierarchy, can be a little expensive to do during a completion request.

I'll try today a bit to see how hard it be to fix in a branch.

kdvolder commented 5 years ago

Closing in favor of: https://github.com/spring-projects/sts4/issues/116