search

spring-attic / spring-integration-kafka

Apache License 2.0
324 stars 180 forks source link

NPE in #onMessage when retryTemplate!=null and recoveryCallback==null #276

Closed ls-urs-keller closed 5 years ago

ls-urs-keller commented 5 years ago

From the code in RetryTemplate it is valid to have no recoveryCallback.

pivotal-issuemaster commented 5 years ago

@urs-ikentoo-com Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 5 years ago

@urs-ikentoo-com Thank you for signing the Contributor License Agreement!

garyrussell commented 5 years ago

Agreed.

artembilan commented 5 years ago

Merged as https://github.com/spring-projects/spring-integration-kafka/commit/6b9d8e22bc6ca562f6aafa04972873e6deab0747. Back-ported to 3.0.x as https://github.com/spring-projects/spring-integration-kafka/commit/7f135baa95016c0413fefc0a027fd27ee90e28f8 after fixing conflicts. Cherry-picked into master as https://github.com/spring-projects/spring-integration-kafka/commit/7f135baa95016c0413fefc0a027fd27ee90e28f8 with some conflict resolutions, too.

@urs-ikentoo-com , thank you very much for your patience and effort. Looking forward for more contributions!