search

spring-attic / spring-integration-kafka

Apache License 2.0
324 stars 180 forks source link

Allow configuration of header-mapper in outbound-channel-adapter XML #287

Closed tomvandenberge closed 4 years ago

tomvandenberge commented 4 years ago

The XML configuration of an outbound-channel-adapter and outbound-gateway currently don't allow configuring a custom KafkaHeaderMapper. The KafkaProducerMessageHandler has a property for it, and it is already possible to set it using the DSL. It seems to be an omission in the XML configuration.

This pull request adds support for this.

tomvandenberge commented 4 years ago

Sure, no problem. Thanks for reviewing!

tomvandenberge commented 4 years ago

Great, I'm happy to be able to contribute a bit.

Will you merge this change to older versions (e.g. 2.3.x), too, or will it only be in the current one?

artembilan commented 4 years ago

this change to older versions

No, we are not going to do that.

The 3.2 version of this project is going to be released today.

As a workaround for the version you are stuck, you always can use a <service-activator> with a reference to a KafkaProducerMessageHandler bean.

Thank you for contribution; looking forward for more!