search

spring-attic / spring-integration-kafka

Apache License 2.0
325 stars 179 forks source link

Move to spring-integration repo #304

Closed sparty02 closed 4 years ago

sparty02 commented 4 years ago

Would you consider moving this to the spring-integration repo? Outside of logically sitting next to the other modules, the practical issue I'm currently hitting is that its not picked up in the spring-integration-bom, which means I unfortunately have to fiddle with managing a version for it, which also lowers some confidence on which versions have been "certified" together.

artembilan commented 4 years ago

Thanks for sharing your pain with us!

Unfortunately we can't do that because Spring Integration main project has different release cycle from this project. And since this project is fully based on the Apache Kafka release cadence, we can't keep them together in the longer releases of Spring Integration.

Also this is not only one Spring Integration extension which has its own release scope. See more here: https://github.com/spring-projects/spring-integration-extensions.

We probably may think about having spring-integration-bom as a separate project which would manage versions for main Spring Integration modules as well as all the supported extensions. But that's hard matter and needs thorough investigation...

@garyrussell , WDYT?

garyrussell commented 4 years ago

That was my initial thought; but things have been quite stable for a while so it might be possible; especially if you plan SI releases aligned with Boot's current cadence.

It's maybe too late for 5.3, but we could consider it in 5.4.

artembilan commented 4 years ago

See here: https://jira.spring.io/browse/INT-3966

artembilan commented 4 years ago

Fixed via: https://github.com/spring-projects/spring-integration/commit/b860a2e818f06a9895ba80b0485e5f073b63c494