maybe we could add primary-classes option for spring-aot generation - Githubissues

spring-attic / spring-native

Spring Native is now superseded by Spring Boot 3 official native support

https://docs.spring.io/spring-boot/docs/current/reference/html/native-image.html

Apache License 2.0

2.74k stars 355 forks source link

maybe we could add primary-classes option for spring-aot generation #1673

Closed wineway closed 2 years ago

wineway commented 2 years ago

this is a draft pr

When we start the spring application:

-               SpringApplication.run(new Class[] {
-                               Xxxx1Configuration.class,
-                               Xxxx2Configuration.class,
-                               Application.class
-               }, args);

spring native creates context using application class and ignores other classes, this will cause some registration of beans to be missing, maybe we can provide the manual configurable option to solve this problem.

Signed-off-by: wineway wangyuweihx@gmail.com

pivotal-cla commented 2 years ago

@wineway Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 2 years ago

@wineway Thank you for signing the Contributor License Agreement!

sdeleuze commented 2 years ago

Thanks for your proposal but Spring Native is now in maintenance mode as we focus more our bandwidth on Spring Framework 6 and Spring Boot 3 native support, so I will close this PR has it is not fixing a critical bug as far as I can say.