spring-attic / spring-security-javaconfig

Spring Security Java Configuration Support (to be merged with spring-security-config)
175 stars 121 forks source link

Usage of raw types. #105

Closed aspan closed 11 years ago

aspan commented 11 years ago

Usage of raw types in the DaoAuthenticationConfigurator and AuthenticationManagerBuilder makes build() require a cast to AuthenticationManager.

    @Bean
    protected AuthenticationManager authenticationManager() throws Exception {
        return (AuthenticationManager) new AuthenticationManagerBuilder().userDetailsService(myUserDetailsService).passwordEncoder(passwordEncoder).and().build();
    }
rwinch commented 11 years ago

Thanks for the pull request. This is now merged.

As an FYI we typically do not put markup into our commit messages (markdown being rendered in commits is a GitHub thing), so if you provide additional commits please try to avoid it.

aspan commented 11 years ago

Thanks for the quick response. I'll avoid markdown in the future.

rwinch commented 11 years ago

No problem on the markdown. The important thing is that you reported the issue and it is certainly a bonus that you fixed it too. Thanks again!