search

spring-attic / spring-security-saml-dsl

Spring security okta dsl.
MIT License
43 stars 61 forks source link

Add final modifier #51

Closed wilder closed 5 years ago

wilder commented 6 years ago

Add final modifier to SAMLConfigurer.java as it doesn't seem to be designed for subclassing.

jchamberlain commented 5 years ago

I'm not sure what the status is on this PR, but my hope is we take the opposite approach and allow SAMLConfigurer to be extended. I currently have the whole thing copied into a project so that I can customize its behavior. I'd much prefer extending the class and overriding what I need to configure.

wilder commented 5 years ago

@jchamberlain yeah, that would really be good! I did exactly the same as you did so I could customize its behavior. I've made this PR because I had some troubles trying to subclass it and thought that the class wasn't designed to be subclassed.

if there are any plans for making it more "customizable" I would be glad to work on it with someone.

fhanik commented 5 years ago

Feel free to open a PR that makes it extendable. I'll close this. I see little benefit adding final to this library given that it' not being actively developed