search

spring-attic / spring-security-saml-dsl

Spring security okta dsl.
MIT License
43 stars 61 forks source link

Adds userDetailsService() to builder #9

Closed ttomsu closed 8 years ago

ttomsu commented 8 years ago

cc @rwinch

jeanbza commented 8 years ago

@ttomsu why the maven publishing plugin? The rest LGTM

markdouglasswork commented 8 years ago

LGTM to me as well. I'm also curious about the maven plugin.

ttomsu commented 8 years ago

I was using it to publishToMavenLocal so that my other project could use and test it:

https://github.com/ttomsu/gate/blob/google-oauth-saml-dsl/gate-web/src/main/groovy/com/netflix/spinnaker/gate/security/saml/SamlSsoConfig.groovy#L104

I made a couple of local edits to assign a bogus version and groupId to get it working. I'd love to learn how to pull it in using just gradle.

jeanbza commented 8 years ago

@ttomsu Could you edit this commit to remove the gradle changes? Once that's done we're happy to accept this.

The tentative plan for people using this is hosting it on spring.io, which should allow people to import it as any other spring dependency.

ttomsu commented 8 years ago

Done.

jeanbza commented 8 years ago

Thank you for the contribution!