search

spring-attic / spring-security-saml

SAML extension for the Spring Security project
Other
419 stars 482 forks source link

SES-118: IDP initiate Single Log Out #109

Closed spring-projects-issues closed 10 years ago

spring-projects-issues commented 11 years ago

patch (Migrated from SES-118) said:

I set the Spring Security SAML Extension as a 'SP' integrated with my web app. Single sign on works fine.

When a user selects global log out from my web app, he is logged out both from SP and IDP and does not allow to access protected web pages again. This is right.

But then a user selects log out from another web app (in the same trust circle). I checked from log that IDP sends samlp:LogoutRequest to SP, and SP sends back saml2p:LogoutResponse with Success to IDP. This user now is certainly logged out from IDP. But it seems this user session is not killed, this user still be able to access protected web pages!!! This is wrong.

spring-projects-issues commented 11 years ago

Vladimir Schäfer said:

Hi Patch,

Can you please tell me which binding is used to send the Logout message from IDP to SP? Is it SOAP?

Vladi

spring-projects-issues commented 11 years ago

patch said:

Hi Vladi,

IDP uses HTTP-redirect binding.

Patch

spring-projects-issues commented 11 years ago

Bernhard Thalmayr said:

Not sure about the side effects, but the following workaround works for me

define a logout handler which destroys HTTP session

<bean id="logoutSessionHandler"
      class="org.springframework.security.web.authentication.logout.SecurityContextLogoutHandler">
    <property name="invalidateHttpSession" value="true"/>
</bean>

use this bean in the in the SAML logout filter

<bean id="samlLogoutProcessingFilter" class="org.springframework.security.saml.SAMLLogoutProcessingFilter">
    <constructor-arg ref="successLogoutHandler"/>
    <constructor-arg ref="logoutSessionHandler"/>
</bean>

About the root cause of the issue ... could this be related to ThreadLocalSecurityContextHolderStrategy being used by default?

spring-projects-issues commented 10 years ago

Vladimir Schäfer said:

Bernhard, thank you for the workaround, it is a correct one.

The real problem was the fact that Spring Security automatically persists changes to the SecurityContext once request.sendRedirect gets called. And that happens once we send LogoutResponse back to server. The problem is that at this point the logout handlers weren't called yet, so the SecurityContext is persisted with the old values. The logout then correctly proceeds, but the changes are never stored.

Fixed in RC3.