Closed oharsta closed 5 years ago
absolutely. open a PR.
@fhanik Thanks for the commit. Our - specific - use case requires support for multiple AuthenticationContextClassReference values in the AuthenticationRequest. I created a new pull request with this small change: https://github.com/spring-projects/spring-security-saml/pull/441
If agreed could I ask you for a new 2.0.0.M30 artifactory release? Thanks again.
We use Spring Security SAML in the OpenID Connect - SAML proxy of SURFnet. We want to support OIDC
acr_values
- Requested Authentication Context Class Reference values. Space-separated string that specifies the acr values that the Authorization Server is being requested to use for processing this Authentication Request and the corresponding SAML<AuthnContextClassRef>
element in the<RequestedAuthnContext>
element.The opensaml libray has support for this in
org.opensaml.saml.saml2.core.RequestedAuthnContext
, but theorg.springframework.security.saml.saml2.authentication.RequestedAuthenticationContext
has not. Proposal is to addAuthnContextClassRef
values to the SpringRequestedAuthenticationContext
and populate these values inOpenSamlImplementation#getRequestedAuthenticationContext
.The
org.springframework.security.saml.saml2.authentication.AuthenticationStatement
has already support for aAuthenticationContextClassReference
in theAuthenticationContext
, however the actual value of theAuthenticationContextClassReference
is limited as it is anenum
. Proposal is to make this a free-format String and change the implementation of the parsing of theList<AuthnStatement>
in OpenSamlImplementation.The SAML specification does not dictate predefined values for the
<AuthnContextClassRef>
element. Cited: A URI reference identifying an authentication context class that describes the authentication context declaration that follows.If agreed with this functionality and the proposed changes I'm more then happy to write a PR in the development branch.