spring-attic / spring-security-saml

SAML extension for the Spring Security project
Other
419 stars 482 forks source link

SAMLProcessingFilter does not respect AuthenticationDetailsSource #466

Open dellekappa opened 4 years ago

dellekappa commented 4 years ago

SAMLProcessingFilter, like any other filters extending AbstractAuthenticationProcessingFilter, should respect what has been setted with setAuthenticationDetailsSource.

The value in this.authenticationDetailsSource is completely ignored by this filter. Furthermore, SAMLAuthenticationProvider drops the authenticationDetails information provided within the Authentication argument in the authenticate method, setting the details of the returned Authentication object with userDetails variable value, but this value is already retrievable by calling getPrincipal on the returned Authentication.