spring-attic / spring-security-saml

SAML extension for the Spring Security project
Other
419 stars 482 forks source link

samples start error #471

Open caorui31 opened 4 years ago

caorui31 commented 4 years ago

image

Cachetian commented 4 years ago

This is a typo in sample/README.md. followings:

    ./gradlew :spring-security-saml-samples/boot/simple-service-provider:bootRun &
    ./gradlew :spring-security-saml-samples/boot/simple-identity-provider:bootRun &

should be:

    ./gradlew :spring-security-saml-samples-boot-simple-service-provider:bootRun &
    ./gradlew :spring-security-saml-samples-boot-simple-identity-provider:bootRun &

Run with below commands, then works fine.

PS: I also faced this issue at first, then I searched the project name and name pattern, I noticed settings.gradle in the root, it writes:

rootProject.children.each { p ->
    p.name = "spring-security-saml2-${p.name}".replace("/","-")
}

so I find the root cause.

jzheaux commented 4 years ago

Good catch, @Cachetian! Would you be willing to submit a PR with the update?