search

spring-attic / spring-social

Allows you to connect your applications with SaaS providers such as Facebook and Twitter.
http://projects.spring.io/spring-social
Apache License 2.0
619 stars 351 forks source link

Changle ConnectController to allow updating existing connections #107

Open daydev opened 11 years ago

daydev commented 11 years ago

If I walk user through connection flow, but there's already connection for this user and provider, DuplicateConnectionException is thrown and an old connection isn't replaced with a new one. This becomes real problem when the old connection is actually expired and so it must be replaced with a new one. I must therefore invent some additional logic to first remove the old connection, and then add the new one. I must go to this trouble, while there exists perfectly capable updateConnection() method in ConnectionRepository.

I propose changing ConnectController, so it will update existing connection on oauth success callback if such connection already exists and create a new one otherwise.

pivotal-issuemaster commented 8 years ago

@daydev Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.