search

spring-attic / spring-social

Allows you to connect your applications with SaaS providers such as Facebook and Twitter.
http://projects.spring.io/spring-social
Apache License 2.0
619 stars 351 forks source link

Changing the OAuth2AuthenticationService to allow for an applicationUrl #115

Closed cl4r1ty closed 10 years ago

cl4r1ty commented 11 years ago

Pull request to address Issue #114

damiancalabresi commented 9 years ago

Hi, this pull request has never been merged. I use the 1.1.0.RELEASE version and still have the same bug, because the redirectUrl cannot be changed when you are behind a proxy server.

cl4r1ty commented 9 years ago

I would suggest updating your configuration to use ConnectionFactories instead of the older way of using the AuthenticationService. I closed this issue and PR due to not longer using this setup.

See https://github.com/spring-projects/spring-social-samples/blob/master/spring-social-showcase/src/main/java/org/springframework/social/showcase/config/SocialConfig.java as an example.

damiancalabresi commented 9 years ago

I'm using the SocialAuthenticationFilter to integrate Spring Social with Spring Security. Do you say it's not recommended? What should I do instead? Use the ProviderSigninController?

Thanks for your reply

cl4r1ty commented 9 years ago

I'd follow the newest spring-social-showcase example config which uses the Connect and SignIn controllers.

damiancalabresi commented 9 years ago

Thanks for your help, I will use this way (This implies many changes in my code). Probably the Spring Social Reference should be updated, because it recommends the SocialAuthenticationFilter when you have a Spring Security Context.