search

spring-attic / spring-social

Allows you to connect your applications with SaaS providers such as Facebook and Twitter.
http://projects.spring.io/spring-social
Apache License 2.0
619 stars 351 forks source link

Move UserConnectionRepository tests to an abstract base class #123

Closed ractive closed 7 years ago

ractive commented 10 years ago
habuma commented 8 years ago

I like what this PR is suggesting, but am going to hold off on merging it for concerns of backward compatibility. Specifically, it adds a new setConnectionSignUp() method to UserConnectionRepository which will break backward compatibility with any implementations of that interface. I see that this PR includes updates to the out-of-the-box implementations, but it can't account for any custom implementations.

This kind of breaking change is not appropriate for a point release. It will certainly be considered for merging when preparing for a future major release.

habuma commented 7 years ago

Merged manually, after resolving some conflicts.