SocialAuthenticationFilter should catch UsernameNotFoundException to enable connection retrieval on authentication failure

spring-attic / spring-social

Allows you to connect your applications with SaaS providers such as Facebook and Twitter.

http://projects.spring.io/spring-social

Apache License 2.0

619 stars 351 forks source link

SocialAuthenticationFilter should catch UsernameNotFoundException to enable connection retrieval on authentication failure #136

Open jkili opened 10 years ago

jkili commented 10 years ago

spring-social / spring-social-security / src / main / java / org / springframework / social / security / SocialAuthenticationFilter.java Line 305

This should catch org.springframework.security.core.userdetails.UsernameNotFoundException not BadCredentialsException (or maybe the super class AuthenticationException) as it means the catch doesn't happen and you cannot get the connection details from the session for signup registration forms.