Better error handling with ProviderSignInController

spring-attic / spring-social

Allows you to connect your applications with SaaS providers such as Facebook and Twitter.

http://projects.spring.io/spring-social

Apache License 2.0

619 stars 351 forks source link

Better error handling with ProviderSignInController #153

Closed codelirium closed 9 years ago

codelirium commented 9 years ago

The ProviderSignInController contains some handlers which can throw exceptions not handled properly. For example: connectionFactoryLocator.getConnectionFactory(providerId) appears to be throwing an IllegalArgumentException which is not caught within the handler's scope to return provide the redirection url but rather gives back a shouty 500. I will fork the repo soon and provide a pull request with a candidate solution.

codelirium commented 9 years ago

Pull request for a fix @ https://github.com/spring-projects/spring-social/pull/154

Kindest regards, Stavros Lekkas (@codelirium)

habuma commented 9 years ago

Merged the PR and it should be available in the latest 1.1.1.BUILD-SNAPSHOT. Will produce a 1.1.1.RELEASE build soon.