search

spring-attic / spring-social

Allows you to connect your applications with SaaS providers such as Facebook and Twitter.
http://projects.spring.io/spring-social
Apache License 2.0
619 stars 351 forks source link

refactor social security code #76

Closed jiwhiz closed 11 years ago

jiwhiz commented 11 years ago

See SOCIAL-345

Extend AbstractAuthenticationProcessingFilter; Change SocialAuthenticationRedirectException to AuthenticationRedirectException and move to spring-security-web; Add Connection<?> to SocialAuthenticationToken; Update unit test;

habuma commented 11 years ago

Any idea why the diffs in the first commit show that every line has changed, even where many lines are visually identical? I suspect this is an encoding difference...but it makes it VERY difficult to review the pull request because I don't have any guidance as to what actually changed.

habuma commented 11 years ago

Looks like DOS line endings. I guess I should set the autocrlf for the project...

jiwhiz commented 11 years ago

I didn't check the difference, sorry for my lack of experience. I did another pull request to see the code changes. Please use the new branch.

habuma commented 11 years ago

Thanks for the new pull request. I'll close this one and focus on the other one.