spring-attic / tut-react-and-spring-data-rest

React.js and Spring Data REST :: A tutorial based on the 5-part blog series by Greg Turnquist
https://spring.io/guides/tutorials/react-and-spring-data-rest
882 stars 1.58k forks source link

Use then instead of done for rest.js callbacks #29

Closed chrylis closed 5 years ago

chrylis commented 8 years ago

As of version 2.0.0, it appears that the Promise returned by the rest.js client call no longer defines a done() method, instead relying on the first argument to then() (more minimally conforming to A+). The AJAX calls seem to work correctly when done is trivially replaced with then.

bolkin commented 8 years ago

I had to set explicit version of rest to 1.3.2 because of the same problem. Also these dependencies are missing from package.json?

diff.txt

gregturn commented 5 years ago

Given rest.js has been archived, there is little value in quibbling over the version used.