Part two, section "Turning on paging from the backend" first curl url missing quotes

spring-attic / tut-react-and-spring-data-rest

React.js and Spring Data REST :: A tutorial based on the 5-part blog series by Greg Turnquist

https://spring.io/guides/tutorials/react-and-spring-data-rest

883 stars 1.58k forks source link

Part two, section "Turning on paging from the backend" first curl url missing quotes #47

Closed jamesyin96 closed 7 years ago

jamesyin96 commented 7 years ago

Hi,

Greg's tutorial is awesome. But when I follow the instruction, I do find that in Part two, the first section regarding "Turning on paging from the backend", it uses the code curl localhost:8080/api/employees?size=2 whose url is not quoted, which will cause "zsh: no matches found: localhost:8080/api/employees?size=2".

I use curl "localhost:8080/api/employees?size=2" and it works fine. Looks like it's a typo.

gregturn commented 7 years ago

Yes, you should wrap a URL with question marks in quotes to avoid this issue. Pull request welcome!

jamesyin96 commented 7 years ago

Thanks. I just submitted the pull request.